[DoNotMerge] Assessment metadata API (Azure Security Center) #6621

tarosler · 2019-07-15T11:36:45Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-07-15T11:38:08Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 50bb9b1d9b2b9eb5bbdd16059784dec6796495c0
  stderr: 'fatal: reference is not a tree: 50bb9b1d9b2b9eb5bbdd16059784dec6796495c0'

AutorestCI · 2019-07-15T11:38:09Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-07-15T11:39:58Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 50bb9b1d9b2b9eb5bbdd16059784dec6796495c0
  stderr: 'fatal: reference is not a tree: 50bb9b1d9b2b9eb5bbdd16059784dec6796495c0'

tarosler · 2019-07-15T11:51:06Z

This PR already approved by ARM in previous PR (https://github.com/Azure/azure-rest-api-specs/pull/6445/files) that merged by mistake. The merge was reverted and I opened a new PR with the same code.

Thanks,
Tal

azuresdkci · 2019-07-15T11:58:40Z

Can one of the admins verify this patch?

openapi-sdkautomation · 2019-08-01T05:09:04Z

SDK Automation [Logs] (Generated from d5d23f1, Iteration 1)

Go: test-repo-billy/azure-sdk-for-go

Package generation pending.

Python: Azure/azure-sdk-for-python [Logs]

Package generation in progress.

JavaScript: Azure/azure-sdk-for-js [Logs]

Package generation in progress.

yungezz · 2019-09-02T01:57:31Z

update from service team via email.

From: Chen Lahav <Chen.Lahav@microsoft.com> 
Sent: Sunday, September 1, 2019 3:48 PM
To: Catherine Zhu <yungez@microsoft.com>; Tal Rosler <Tal.Rosler@microsoft.com>
Subject: RE: about PR https://github.com/Azure/azure-rest-api-specs/pull/6621

Hi Catherine,
We are in a Private Preview processes, we will probably go public by end of month and complete the PR then
Currently private preview customers are using the files from the fork for documentation

Thanks,
Chen

yungezz · 2019-10-10T01:33:49Z

HI @tarosler any update?

tarosler · 2019-10-10T15:37:21Z

HI @tarosler any update?

@chlahav who is the owner of this PR now

yungezz · 2019-10-17T06:44:25Z

HI @chlahav what's next step of this PR? any update?

yungezz · 2019-10-21T01:37:50Z

HI @chlahav what's next step of this PR? any update?

tarosler and others added 15 commits June 20, 2019 17:24

create assessmentMetadata.json

7d4b120

update

59d31c7

update

069fa75

update

c1cc699

update

cba198c

update

bb13beb

fix

ce7047a

Add examples

94e9adc

fix CR comments

1083840

build fixes

439b920

fix build

566c1c1

add API to readme

97b1d9b

fix unit test

89482dc

fix operation id

0e6a903

Merge branch 'master' into master

d5d23f1

AutorestCI mentioned this pull request Jul 15, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-python#6346

Closed

AutorestCI mentioned this pull request Jul 15, 2019

[AutoPR security/resource-manager] Assessment metadata API (Azure Security Center) Azure/azure-sdk-for-go#5250

Closed

chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 15, 2019

yungezz approved these changes Jul 15, 2019

View reviewed changes

yungezz changed the title ~~Assessment metadata API (Azure Security Center)~~ [DoNotMerge] Assessment metadata API (Azure Security Center) Aug 1, 2019

yungezz self-assigned this Aug 2, 2019

eliagrady mentioned this pull request Oct 24, 2019

Assessment metadata API (Azure Security Center) #7622

Merged

5 tasks

yungezz closed this Oct 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DoNotMerge] Assessment metadata API (Azure Security Center) #6621

[DoNotMerge] Assessment metadata API (Azure Security Center) #6621

tarosler commented Jul 15, 2019

AutorestCI commented Jul 15, 2019 •

edited

Loading

AutorestCI commented Jul 15, 2019 •

edited

Loading

AutorestCI commented Jul 15, 2019 •

edited

Loading

tarosler commented Jul 15, 2019

azuresdkci commented Jul 15, 2019

openapi-sdkautomation bot commented Aug 1, 2019 •

edited

Loading

yungezz commented Sep 2, 2019

yungezz commented Oct 10, 2019

tarosler commented Oct 10, 2019

yungezz commented Oct 17, 2019

yungezz commented Oct 21, 2019

[DoNotMerge] Assessment metadata API (Azure Security Center) #6621

[DoNotMerge] Assessment metadata API (Azure Security Center) #6621

Conversation

tarosler commented Jul 15, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Jul 15, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 15, 2019 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 15, 2019 • edited Loading

Automation for azure-sdk-for-go

tarosler commented Jul 15, 2019

azuresdkci commented Jul 15, 2019

openapi-sdkautomation bot commented Aug 1, 2019 • edited Loading

SDK Automation [Logs] (Generated from d5d23f1, Iteration 1)

yungezz commented Sep 2, 2019

yungezz commented Oct 10, 2019

tarosler commented Oct 10, 2019

yungezz commented Oct 17, 2019

yungezz commented Oct 21, 2019

AutorestCI commented Jul 15, 2019 •

edited

Loading

AutorestCI commented Jul 15, 2019 •

edited

Loading

AutorestCI commented Jul 15, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 1, 2019 •

edited

Loading